Remove "Include selection" checkbox

[dlqqq]

Problem

The current UI for including a selection with your prompt is confusing. It requires a user to make a text selection in the main panel, after which the "Include selection" checkbox will appear. If a user checks this box, the checkbox remains checked until the user unchecks it manually while still having a text selection.

Proposed Solution

Instead, we should implement this capability as a new feature of the "Send message" button, specifically by making it a dropdown button like the Send button in Slack's UI. Within the dropdown menu that is opened on click, there should be two additional options: "Send with text selection" and "Send with cell selection".

Additional context

Sample image from Slack's UI:

[labarba]

Oh no. I really liked the checkbox for "include selection," and found it immediately intuitive. Was there any user testing that led to this issue being opened?

[dlqqq]

@labarba We received feedback from several users about the current state of "Include selection". The 3 most prominent points of feedback were:

1. After clicking the "Include selection" checkbox once, the checkbox remains checked until the user manually unchecks it. Some users found this especially confusing because they would forget to uncheck this, and subsequent queries to Jupyternaut would generate weird responses because they were still including a previous text selection which is irrelevant to the current query.
2. The current "Include selection" UI only allows including a text selection, but does not allow for including a cell selection. This is a problem for users trying to include large code cells, which are difficult to select entirely if the user doesn't know the Cmd + A keyboard shortcut.
3. The "Include selection" checkbox appears out of nowhere and pushes up the chat input & send button after a selection is made. For important UI actions like the chat input & send button, they should remain fixed as much as possible. Furthermore, there should be some indication that sending with a text selection is possible within Jupyter AI, before a user makes a text selection.

Using a dropdown button that contains a menu would address these concerns by:

1. Making "Include selection" a "one-off" action instead of a persistent action,
2. Allowing the user to choose between including a text selection or the active cell,
3. Showing the user the options for including a text/cell selection even before one is made.

Hopefully this offers insight into why we are changing the "Include selection" experience here.

We will iterate on this and include it in a future release for users to try. If you have any feedback regarding this feature once it's released, please feel free to open an issue and let us know! We're certainly open to reverting this change if the community isn't pleased with it.

[labarba]

Greatly appreciate this explanation and background. I guess I've grown used to the UI quirks and I automatically do the clicks I need to do now. But I can see how users might experience what you describe. Godspeed!