Cannot release

[davidbrochart]

Description

I tried to release jupyter-collaboration but it seems that I can't anymore. I did change my PyPI token recently but I updated it in my fork of jupyter-releaser's secrets. I also tried self-releasing, but that failed too.
Maybe @blink1073 has ideas?

[jtpio]

I think we should update the workflows: #262

[davidbrochart]

@blink1073 it failed at the NPM stage.

[blink1073]

Ugh, I pushed this change to the wrong remote, can you please apply this diff?

--- a/.github/workflows/publish-release.yml
+++ b/.github/workflows/publish-release.yml
@@ -38,6 +38,8 @@ jobs:

       - name: Finalize Release
         id: finalize-release
+        env:
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         uses: jupyter-server/jupyter_releaser/.github/actions/finalize-release@v2
         with:
           token: ${{ steps.app-token.outputs.token }}

[davidbrochart]

hmm stil failing.

[blink1073]

I just set it to the npm token for the @jupyter org.

[davidbrochart]

Not sure it was that, see this.

[blink1073]

I'm not sure, I don't work in npm-land anymore. :)

[krassowski]

Cryptic npm ERR! code E404 - great! I asked on npm/feedback#1099.

[krassowski]

I think that the problem is with configuration on npm. I do not see @jupyter-releaser-bot as a contributor listed there, even though it is listed on https://www.npmjs.com/package/@jupyter-notebook/application

It looks like the release went through half an hour ago but without provenance, I guess someone uploaded it manually? https://www.npmjs.com/package/@jupyter/collaboration

[krassowski]

I think I do not have permissions to add the bot to the appropriate team or add the package to the team where the bot is. @jtpio can you take a look?

[davidbrochart]

@Zsailer did a manual release, thank you!

• https://github.com/jupyterlab/jupyter-collaboration/releases/tag/v2.0.11
• https://pypi.org/project/jupyter-collaboration/2.0.11/
• https://www.npmjs.com/package/@jupyter/collaboration/v/2.0.11

[jtpio]

OK the jupyter-releaser-bot npm account should now be a member of the jupyter organization.

[jtpio]

I don't know if npm plans to implement something like the PyPI trusted publishers. But if they do we could get rid of that bot.

[blink1073]

Supposedly it is coming eventually: https://github.blog/2023-04-19-introducing-npm-package-provenance/#looking-ahead

[krassowski]

@davidbrochart I will try to make a new alpha release using the GH action to see if everything is in order after the recent refactor #280.

[krassowski]

The upload step failed:

Fetching PyPI API token...
Handling dist file dist/jupyter-collaboration-3.0.0-alpha.0.tgz
COMMAND: npm publish --tag next jupyter-collaboration-3.0.0-alpha.0.tgz
Handling dist file dist/jupyter-collaboration-extension-3.0.0-alpha.0.tgz
COMMAND: npm publish --tag next jupyter-collaboration-extension-3.0.0-alpha.0.tgz
Handling dist file dist/jupyter-docprovider-3.0.0-alpha.0.tgz
COMMAND: npm publish --tag next jupyter-docprovider-3.0.0-alpha.0.tgz
Handling dist file dist/jupyter-docprovider-extension-3.0.0-alpha.0.tgz
COMMAND: npm publish --tag next jupyter-docprovider-extension-3.0.0-alpha.0.tgz
Handling dist file dist/jupyter_collaboration-3.0.0a0-py3-none-any.whl
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-collaboration does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_collaboration-3.0.0a0-py3-none-any.whl
  lib.publish_assets(
Handling dist file dist/jupyter_collaboration-3.0.0a0.tar.gz
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-collaboration does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_collaboration-3.0.0a0.tar.gz
  lib.publish_assets(
Handling dist file dist/jupyter_collaboration_ui-1.0.0a0-py3-none-any.whl
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-collaboration-ui does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_collaboration_ui-1.0.0a0-py3-none-any.whl
  lib.publish_assets(
Handling dist file dist/jupyter_collaboration_ui-1.0.0a0.tar.gz
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-collaboration-ui does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_collaboration_ui-1.0.0a0.tar.gz
  lib.publish_assets(
Handling dist file dist/jupyter_docprovider-1.0.0a0-py3-none-any.whl
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-docprovider does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_docprovider-1.0.0a0-py3-none-any.whl
  lib.publish_assets(
Handling dist file dist/jupyter_docprovider-1.0.0a0.tar.gz
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-docprovider does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_docprovider-1.0.0a0.tar.gz
  lib.publish_assets(
Handling dist file dist/jupyter_server_ydoc-1.0.0a0-py3-none-any.whl
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-server-ydoc does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_server_ydoc-1.0.0a0-py3-none-any.whl
  lib.publish_assets(
Handling dist file dist/jupyter_server_ydoc-1.0.0a0.tar.gz
/home/runner/work/_actions/jupyter-server/jupyter_releaser/v2/jupyter_releaser/cli.py:676: UserWarning: Python package name jupyter-server-ydoc does not match with name in jupyter releaser config: jupyter_docprovider. Skipping uploading dist file dist/jupyter_server_ydoc-1.0.0a0.tar.gz
  lib.publish_assets(

It looks like releaser compares the name of each python packages against jupyter_docprovider (not sure why) and gives up.

The packages for releaser are defined in:

jupyter-collaboration/pyproject.toml

Lines 61 to 69 in a3b4984

	[tool.jupyter-releaser.options]
	# `--skip-if-dirty` is a workaround for https://github.com/jupyter-server/jupyter_releaser/issues/567
	version-cmd = "cd ../.. && python scripts/bump_version.py --force --skip-if-dirty"
	python_packages = [
	"projects/jupyter-server-ydoc:jupyter-server-ydoc",
	"projects/jupyter-collaboration-ui:jupyter-collaboration-ui",
	"projects/jupyter-docprovider:jupyter-docprovider",
	"projects/jupyter-collaboration:jupyter-collaboration"
	]

Looking at the jupyter-releaser source here it is not clear why it would be comparing against a fixed string each time.

[krassowski]

So the upload issue should be fixed by jupyter-server/jupyter_releaser#568, but the check release is failing with:

ValueError: Tag v1.0.0 already exists! To delete run: `git push --delete origin {tag_name}`

I opened jupyter-server/jupyter_releaser#570 proposing a fix for this.

[Zsailer]

I think this is fixed now.

I was able to make a release, 3.0.0.alpha1, so closing this issue for now.