Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completer manager plugin is named :tracker but probably should be :manager #13669

Closed
krassowski opened this issue Dec 27, 2022 · 1 comment · Fixed by #13910
Closed

Completer manager plugin is named :tracker but probably should be :manager #13669

krassowski opened this issue Dec 27, 2022 · 1 comment · Fixed by #13910

Comments

@krassowski
Copy link
Member

I noticed that the completer-extension manager plugin is named as :tracker:

const COMPLETION_MANAGER_PLUGIN = '@jupyterlab/completer-extension:tracker';

I would think that :manager is more appropriate here as it is not a tracker. Is this a copy-paste error, or was this intended? On 3.x branch we did have a :manager too (but with a different API).

CC @trungleduc

@krassowski krassowski added question pkg:completer status:Needs Triage Applied to new issues that need triage labels Dec 27, 2022
@krassowski krassowski added this to the 4.0.0 milestone Dec 27, 2022
@JasonWeill JasonWeill added maintenance and removed status:Needs Triage Applied to new issues that need triage labels Dec 29, 2022
@trungleduc
Copy link
Member

I think this is a copy-paste error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants