-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accessible indication of successful copy to clipboard #14827
Comments
Piggy backing here because a way to show a transient toast would be also useful for:
I did not find any docs on how to achieve this with notifications yet. @fcollonval do you remember if transient toast notifications are already possible in core, or would we need to implement it? Though for the most part I think we should only show toast when there is no place to show transient clipboard success animation in-place (next to the thing which is being copied). |
For the record: I'm _against_ out-of-line toast, status bar, etc. as being
the _only_ thing. They annoy me personally (I turn them off whenever
possible), and probably aren't very accessible.
Tooltip _could_ be reasonable, but does a poor job of showing the extent of
what was copied... an accessible status message could include e.g. the
number of bytes, I suppose, but "fake" clipboard stuff like cells might
just say "3 cells".
|
Some additional thoughts: Specifically in the notebook case (which wouldn't help e.g. equations in a rendered markdown document): another area which can't be hidden is the prompt area... while it's not guaranteed to be very big (one line, about 70px) it could house temporary icon-sized indicators, which would be closer to the thing of interest. All MainAreaWidgets have a toolbar area (even if it's often empty and collapsed). In the notebook case, this is already very busy, and can collapse (unexpectedly) to the ellipsis, but could show a bit more content (if temporarily), but would run the risk of reflowing the toolbar... and potentially triggering the ellipsis condition. A larger-than-icon use of real estate would be poor, for the most part, unless it was a gateway to some kind of "history of my commands" view, which resulted in... something (e.g. a save/export for command macros). Way out of scope here, as teasing out the context of user commands (and filtering out the boring ones) would be... really hard. |
In the notification center, no; it is basically a logger. But yes, the toast pop up has a |
Problem
A number of commands and other UI elements allow for copying... something to the user's (or lab's internal) clipboard, but there is no consistent visual (or announceable) indication that it was successful.
Some examples:
ctrl+c of text selected by the caret (either with mouse or keyboard) seems to generally not be an reported activity, so this is really concerned more with non-traditionally selected things.
Proposed Solution
Some alternatives:
jp-mod-copied
utility class that uses some minimally-reflowing CSS transition (e.g.outline
) to indicate that a copy has successfully occurred, then disappear, without a lot of flickerAdditional context
Considering this over #14102 where I'm trying to emulate some of the MathJax patterns for discoverability/ownership of rendered diagrams (e.g. in MIME outputs).
The text was updated successfully, but these errors were encountered: