Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move over initial shim logic #1

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[WIP] Move over initial shim logic #1

merged 1 commit into from
Jan 26, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 19, 2022

This copies logic from jupyterlab/nbclassic to handle shimming of notebook traits in Jupyter server extensions.

I'm opening the PR before it's ready for review. There are some subtle things in here that might need discussions and I likely work on this in chunks over the next week.

@jtpio

@welcome
Copy link

welcome bot commented Jan 19, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

RELEASE.md Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jan 25, 2022

FYI @Zsailer I pushed a couple of commits to this branch to add the CI check release workflow and address the comments above.

Probably we would have to merge this first to trigger the CI as the checks don't seem to be running at the moment.

@jtpio jtpio added the enhancement New feature or request label Jan 25, 2022
@Zsailer Zsailer marked this pull request as ready for review January 26, 2022 17:00
@Zsailer
Copy link
Member Author

Zsailer commented Jan 26, 2022

@jtpio, I'm going to merge this as-is. It's currently broken, but we can iterate.

@Zsailer Zsailer merged commit d54788b into jupyter:main Jan 26, 2022
@welcome
Copy link

welcome bot commented Jan 26, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jtpio
Copy link
Member

jtpio commented Jan 26, 2022

Alright thanks @Zsailer 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants