Add some file system tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds playwright tests related to the file system. These tests modify files/directories by running shell commands such as
cpandtouch, and checks that the changes are reflected in the JupyterLite contents manager.To do this I hot swap the JupyterLab
galataContentsHelperhttps://github.com/jupyterlab/jupyterlab/blob/9fb90cab96a67bef9050ab7cf917eb3cfdb55414/galata/src/contents.ts#L20
which works via the REST API for a different
ContentsHelperwhich is part-implemented in this PR and uses the JupyterLite contents manager instead.I am following the
ContentsHelperapproach to keep consistent withgalata. This approach might be useful upstream in JupyterLite for tests like these:https://github.com/jupyterlite/jupyterlite/blob/ac544cc2a2836aa8cb74fb280b2488bf43157e99/ui-tests/test/contents.test.ts#L33-L44