Replies: 2 comments 3 replies
-
Beta Was this translation helpful? Give feedback.
-
|
PR for the docs: jurassiscripts/velociraptor-dot-run#2 |
Beta Was this translation helpful? Give feedback.
-
|
Hey @nnmrts, I completely agree and would like to take the occasion to uniform the option names to Deno's ones (#95 as well). I would probably keep the existing names as additional aliases for backward compatibility. Would you mind adding the |
Beta Was this translation helpful? Give feedback.
-
|
I have to admit a mistake though, Deno uses |
Beta Was this translation helpful? Give feedback.
-
|
Pushed a fix regarding this to the PR but I think I should wait on your thoughts on this before going forward...sorry for the mistake, don't really know how I missed that. Seems like Deno changed it from Compare: |
Beta Was this translation helpful? Give feedback.
-
This would have several positive implications:
--importmapnot--imap. Users, especially new ones, probably expect vr to use the same names for options like these.importmapas well. This was the main motivation for this feature request, as changing this option toimportmapin vr would make the config formats of both "compatible", in the sense that one doesn't have to add bothimapandimportmapoptions to their config files. Note that it's still not really possible to use one config file for both vr and denon due to denon using thescripts.config.<EXT>format for dynamic config files for some reason. I'll create PR for this at the denon repo.imapis not unambiguous and also not widely used elsewhere across the Deno community, as far as I know.I'll create two PRs for this, one breaking and one non-breaking, by adding a deprecation notice when using
imap.Beta Was this translation helpful? Give feedback.
All reactions