Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #19

Open
SampsonCrowley opened this issue Oct 22, 2020 · 2 comments
Open

Testing #19

SampsonCrowley opened this issue Oct 22, 2020 · 2 comments

Comments

@SampsonCrowley
Copy link

@justalever I loved your writeup attached to this repo, except it doesn't really provide any insight into your advice on testing this functionality either through Jest/karma/mocha (JS) etc... or in the system tests

@justalever
Copy link
Owner

Hey thanks! Testing and such I left out to reduce the overhead of the guide. It's certainly a worthy additional step should you require it. You'd probably need both JS tests and tests on the server-side.

@SampsonCrowley
Copy link
Author

I'm in the process of trying to write up both system tests with rails and javascript testing through jest. I was hoping you might already have some basics to build on like the rest of the article, but since not, I'll be sure to submit what I come up with to the repo!

Even if it adding it to the article would be too heavy (which I agree with), having some examples in the source repo I think should be enough to get most people started in their own use cases

Side Note: I'd personally recommend renaming DirectUploadController (in dropzone_controller.js) to DirectUploadManager or even just UploadManager since it's not a controller in the stimulus sense, and that might be confusing to some less knowledgeable readers; but certainly not a big enough deal to be a real issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants