Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cpu_only a make/cmake toggle and drop the cpu_only branch ? #16

Closed
AdelKS opened this issue Mar 9, 2022 · 5 comments
Closed

Make cpu_only a make/cmake toggle and drop the cpu_only branch ? #16

AdelKS opened this issue Mar 9, 2022 · 5 comments

Comments

@AdelKS
Copy link

AdelKS commented Mar 9, 2022

Hello!

To simplify packaging (I want to write an ebuild for Gentoo's GURU) so the code given in the releases tarballs can be used directly, it would be awesome if you could merge the cpu_only into master and make it into a cmake toggle for example, and/or maybe make the GPU queuing a toggle. Is it very difficult for you ? Another option is to add the cpu_only source code to the releases.

Thanks!

Adel

@justanhduc
Copy link
Owner

Hi @AdelKS. It's a good idea. The first option is what I have been longing for. However, I suppose it will require some restructuring of the codes, which currently I cannot find time for. The second option is can be a short-term solution, but doing so will lose all history of the cpu-only branch. Btw, there is a tar ball for the cpu-only branch in each release (for e.g., here. Is it not what you need?

@AdelKS
Copy link
Author

AdelKS commented Mar 10, 2022

Thanks for your answer! Good luck!

Btw, there is a tar ball for the cpu-only branch in each release (for e.g., here. Is it not what you need?

I did not see it as I only checked the "Releases" page and not the tags, that one is good yes ! Thank you

@justanhduc
Copy link
Owner

Hey @AdelKS. Finally I could merge the two branches together! Please check out the latest master. Maybe it's not stable for now, but so far I haven't encountered any problem.

@AdelKS
Copy link
Author

AdelKS commented Sep 18, 2022

Hello @justanhduc, sorry for the late answer, I was busy with other projects ! :D

Okay, I tried to compile master and unfortunately I cannot see a cmake toggle to disable GPU support, and I get this error message:

CMake Error at /usr/share/cmake/Modules/CMakeDetermineCUDACompiler.cmake:180 (message):
  Failed to find nvcc.

  Compiler requires the CUDA toolkit.  Please set the CUDAToolkit_ROOT
  variable.

@justanhduc
Copy link
Owner

justanhduc commented Sep 21, 2022

Hi @AdelKS. I will investigate it. But I think installing using make should work because it is the main method I use during development while CMake is a bit an afterthought. Please try installing via make. Thanks for noticing me this problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants