-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Monitoring #60
Comments
That is not in the planning yet, but is is a great feature request! 😄 I have put it on the planning, in the meantime PRs are always welcome 🙂 |
@webtekindo what should we add for this? As far as I can see, you just have to add |
@peterjaap does the plugin pass the |
@salmino you're right. It does not. But with #90, you can easily enable the performance monitoring to test it. I'm running a test now, if it's successful, I'll create a PR to add it to this extension. I've created an observer that does this; $observer->getEvent()->getConfig()->setTracesSampleRate(1.0); Or you could use the sampler; $observer->getEvent()->getConfig()->setTracesSampler(function (\Sentry\Tracing\SamplingContext $context): float {
return 1.0;
}); |
If you run it in production and especially if you have a high sample rate, please use Relay. |
I guess this doesn't do anything since we should probably find a way to create these "Transactions" they're speaking of. Now, this extension only fires when an actual exception is being thrown. |
Ah, here's some more info on how to create those transactions; https://docs.sentry.io/platforms/php/performance/instrumentation/custom-instrumentation/ |
Maybe we could get some inspiration from https://github.com/yireo/Yireo_NewRelic2 |
Proof of concept: #106 |
Is performance monitoring working? |
Is there any plan to be able to use https://docs.sentry.io/product/performance/getting-started/ with this extension? Thank you.
The text was updated successfully, but these errors were encountered: