-
Notifications
You must be signed in to change notification settings - Fork 15
Let's implement it #1
Comments
On keybindings, I'd like to reply to some suggestions raised by @vyp .
Jumping in vim is largely handled by Also, maybe it is worth exploring equivalent vim plugins, such as Fugitive. |
I encourage people to participate to this design although I'm not really for it in Spacemacs because there is an automatic way of making any maps Vim compatible by defining a minimal set of Vim keys and applying rules to them. I find this method robust, consistent, future proof and maintenance hassle free (we cannot design all the modes of the earth manually for evil). Since Magit can handle a top quality Evil integration because it has the community to do it, I won't be against using it in Spacemacs but the ideal implementation would allow the users to be able to dynamically opt-out/opt-in for this integration. All in all I have few interest in participating to this design but I encourage people to do it! |
@syl20bnr Thanks for your encouragement! |
In the old thread someone requested a list of keymaps. Here it is: (defvar magit-keymaps
'(git-commit-mode-map
git-rebase-mode-map
magit-blame-mode-map
magit-blob-mode-map
magit-branch-section-map
magit-cherry-mode-map
magit-commit-section-map
magit-diff-mode-map
magit-file-mode-map
magit-file-section-map
magit-hunk-section-map
magit-log-mode-map
magit-log-read-revs-map
magit-log-select-mode-map
magit-minibuffer-local-ns-map
magit-module-commit-section-map
magit-popup-mode-map
magit-process-mode-map
magit-reflog-mode-map
magit-refs-mode-map
magit-remote-section-map
magit-staged-section-map
magit-stash-section-map
magit-stashes-section-map
magit-status-mode-map
magit-tag-section-map
magit-unpulled-section-map
magit-unpushed-section-map
magit-unstaged-section-map
magit-untracked-section-map
with-editor-mode-map)) |
Thanks to magit/magit@cc92034 it now probably is unnecessary to modify section keymaps for use with Evil. Or at least fewer of them. |
Were it all began: magit/magit#1968.
That discussion contains some suggestions which seem reasonable to a layman like me. Please create a branch and import your configuration. When that is ready create a commit on the
master
which describes your configuration inREADME.md
. Then rebase your work on top of that and ask for push permissions. Finally push that one descriptive commit tomaster
(and only that) and your implementation to the branchYOUR_GITHUB_USERNAME
.The text was updated successfully, but these errors were encountered: