New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a page header landmark #4

Open

garcialo opened this issue Jul 14, 2018 · 0 comments

Contributor

garcialo commented Jul 14, 2018

Change:
Divs surrounding the header content should be changed to header elements.

I think it's these two divs:

new-site/src/components/Navbar.js

Line 36 in 6141dfe

<div className="navbar" style={{ osition: "fixed" }}>

new-site/src/components/Navbar.js

Line 70 in 6141dfe

<div className="navbar" style={{ position: "fixed" }}>

Rationale:
Using a header element will allow screen reader users to more easily navigate to this part of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment