Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/s3 #54

Merged
merged 10 commits into from
Apr 23, 2021
Merged

Feature/s3 #54

merged 10 commits into from
Apr 23, 2021

Conversation

justindujardin
Copy link
Owner

@justindujardin justindujardin commented Apr 23, 2021

Add support for S3 bucket access. To use, install the s3 package extras:

pip install pathy[s3]

Then you can use s3 paths similarly to gs ones:

from pathy import Pathy

a = Pathy("s3://pathy-tests-bucket/myfile.txt")
a.touch()
a.write_text("Hello World!")
assert a.read_text() == "Hello World!"

If you install the gcs extras too, you can do neat things like copy files from one service to another:

pip install "pathy[s3,gcs]"
pathy cp gs://bucket/copy.zip s3://bucket/file.zip

Changes

  • Update tests to change schemes based on the adapter being tested
  • Add s3 client adapter / tests
  • Add cloud platform support table to readme

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #54 (6f139ce) into master (ecbc5fa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #54    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            4         5     +1     
  Lines          884      1027   +143     
==========================================
+ Hits           884      1027   +143     
Impacted Files Coverage Δ
pathy/__init__.py 100.00% <100.00%> (ø)
pathy/s3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbc5fa...6f139ce. Read the comment docs.

@justindujardin justindujardin added the enhancement New feature or request label Apr 23, 2021
@justindujardin justindujardin marked this pull request as ready for review April 23, 2021 23:06
@justindujardin justindujardin added the s3 Relates to S3 implementation label Apr 23, 2021
@justindujardin justindujardin merged commit 5bb7e1b into master Apr 23, 2021
@justindujardin justindujardin deleted the feature/s3 branch April 23, 2021 23:13
github-actions bot pushed a commit that referenced this pull request Apr 23, 2021
## [0.5.1](v0.5.0...v0.5.1) (2021-04-23)

### Features

* **clients:** add support for S3 bucket storage ([#54](#54)) ([5bb7e1b](5bb7e1b))
@github-actions
Copy link

🎉 This PR is included in version 0.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released s3 Relates to S3 implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant