feat: support smart_open >=5.0.0,<6.0.0 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This change removes support for smart_open < 5.0.0 The API for specifying s3 credentials changed in smart_open v5, so previous versions are incompatible.
justindujardin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1028 1030 +2
=========================================
+ Hits 1028 1030 +2
Continue to review full report at Codecov.
|
- use inline if/else to keep line coverage up
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2021
# [0.6.0](v0.5.2...v0.6.0) (2021-06-26) ### Features * support smart_open >=5.0.0,<6.0.0 ([#63](#63)) ([9718752](9718752)) ### BREAKING CHANGES * This change removes support for smart_open < 5.0.0 The API for specifying s3 credentials changed in smart_open v5, so previous versions are incompatible.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smart_open API for specifying s3 bucket credentials changed in v5.0.0.
Fixes #61