fix(stat): return BlobStat for all pathy paths #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement `stat` in `BasePath` and yield `BlobStat`s instead of `os.stat_result`. - implement all the pathlib file mode checking helpers because they use `self.stat()` internally which doesn't work with BlobStats. - add tests for base path helpers - update CLI test to assert that stats are BlobStat now BREAKING CHANGE: Previously when using Pathy.fluid paths that point to local file system paths, Pathy would return an `os.stat_result` rather than a `BlobStat`. This made it difficulty to treat mixed paths consistently. Now Pathy returns a BlobStat structure for local and remote paths. If you need to use `os.stat_result` you can still call `os.stat(my_path)` to access it.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1125 1159 +34
=========================================
+ Hits 1125 1159 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- seems related to : actions/setup-python#162 - a fix is to use ubuntu 20.04, and we don't NEED latest for anything. We can switch this back later if the issue gets resolved.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# [0.10.0](v0.9.0...v0.10.0) (2022-11-23) ### Bug Fixes * **stat:** return BlobStat for all pathy paths ([#96](#96)) ([f092605](f092605)) ### BREAKING CHANGES * **stat:** Previously when using Pathy.fluid paths that point to local file system paths, Pathy would return an `os.stat_result` rather than a `BlobStat`. This made it difficulty to treat mixed paths consistently. Now Pathy returns a BlobStat structure for local and remote paths. If you need to use `os.stat_result` you can still call `os.stat(my_path)` to access it.
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
BlobStatconsistently for local and remote paths.Changes
statinBasePathand yieldBlobStats instead ofos.stat_result.self.stat()internally which doesn't work with BlobStats.BREAKING CHANGE: Previously, when using Pathy.fluid paths that point to local file system paths, Pathy would return an
os.stat_resultrather than aBlobStat. This made it difficult to treat mixed paths consistently.Now Pathy returns a BlobStat structure for local and remote paths.
If you need to use
os.stat_result, you can still callos.stat(my_path)to access it.