Skip to content

Could it support vm.newSymbol()? #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fake-car opened this issue Jul 13, 2022 · 1 comment · Fixed by #105
Closed

Could it support vm.newSymbol()? #71

fake-car opened this issue Jul 13, 2022 · 1 comment · Fixed by #105

Comments

@fake-car
Copy link

There are many scenes of using Symbol, but I cant make it with vm.newSymbol. I see JS_NewAtomWithSymbol and JS_SymbolGetIterato in quickjs. Can you add it? Really appreciate it.
@justjake
Copy link
Owner

I’m happy to accept a PR for this.

The README should cover how the Typescript API is generated for C functions. is there any more guidance you need?

@justjake justjake mentioned this issue Feb 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extended Symbol support justjake/quickjs-emscripten
2 participants
@justjake @fake-car