Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joplin.repl/reset and Joplin.repl/seed don't close connections #116

Open
bmfisher opened this issue Jul 24, 2020 · 1 comment
Open

Joplin.repl/reset and Joplin.repl/seed don't close connections #116

bmfisher opened this issue Jul 24, 2020 · 1 comment

Comments

@bmfisher
Copy link

Using joplin.repl/reset to roll back and migrate changes to a postgresql db and it doesn't close the connections it opens. I quickly reach my connection limit and have to force kill my postgres instance.

My joplin.edn config defines my only database with {:type :sql, :url "jdbc:postgresql://localhost:5432/my-database?user=postgres&password=postgres"}

I have a separate psql client open to the postgres instance and run select * from pg_stat_database;. The numbackends which are connections to my database goes up by 10 each time I run reset (I have 5 roll backs and 5 migrations so presumably one new connection for each). Running joplin.repl/rollback and joplin.repl/migrate separately correctly closes all connections.

@bmfisher bmfisher changed the title Joplin.repl/reset doesn't close connections Joplin.repl/reset and Joplin.repl/seed don't close connections Jul 24, 2020
@bmfisher
Copy link
Author

Same behavior exhibited by Joplin.repl/seed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant