Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the promotions in ranges causes package tests to fail. #2

Closed
KristofferC opened this issue Mar 7, 2022 · 5 comments
Closed

Comments

@KristofferC
Copy link

After JuliaLang/julia#43059 there is a change in the result of range when it comes to mixed input types:

julia> start, step, length = (2.0, -1, 5)
(2.0, -1, 5)

julia> Base.range(start; step, length) |> typeof # 1.8
StepRangeLen{Float64, Float64, Int64, Int64}

julia> Base.range(start; step, length) |> typeof # 1.7
StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}, Int64}

This causes some tests in this package (that check === ) to fail, see the PkgEval report https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/fb69baf_vs_40279f9/RangeHelpers.primary.log.

@jw3126
Copy link
Owner

jw3126 commented Mar 7, 2022

Thanks for reporting!

@KristofferC
Copy link
Author

This might be an issue on Julia's side though it seems.

@jw3126
Copy link
Owner

jw3126 commented Mar 8, 2022

Ok, I think I will wait until 1.8 comes out and then fix any remaining test fails.

@KristofferC
Copy link
Author

I think should be fixed by JuliaLang/julia#44528

@KristofferC
Copy link
Author

Indeed, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants