Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether a menu is empty elegantly #142

Closed
lenormf opened this issue Jul 20, 2021 · 1 comment
Closed

Check whether a menu is empty elegantly #142

lenormf opened this issue Jul 20, 2021 · 1 comment
Labels
Feature Request Add for a new feature request Widgets Add for issues having to do with widgets
Milestone
v0.1.5

Comments

@lenormf
Copy link

lenormf commented Jul 20, 2021

Is your feature request related to a problem? Please describe.
I currently have to rely on get() returning None to check whether a menu is empty, which is inelegant. I can't check the index of the currently selected item either because of #139.

Describe the solution you'd like
An implementation of empty() on menu classes.
@lenormf lenormf added the Feature Request Add for a new feature request label Jul 20, 2021
@jwlodek jwlodek added this to the v0.1.5 milestone Oct 2, 2021
@jwlodek jwlodek added the Widgets Add for issues having to do with widgets label Oct 2, 2021
@jwlodek jwlodek mentioned this issue Dec 29, 2021
Merged
3 tasks
@jwlodek
Copy link
Owner

jwlodek commented Dec 29, 2021

This is now fixed on the v0.1.5 branch with a new is_empty function for menus.

@jwlodek jwlodek closed this as completed Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Add for a new feature request Widgets Add for issues having to do with widgets
Projects
None yet
Milestone
v0.1.5
Development

No branches or pull requests
2 participants
@lenormf @jwlodek