This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Pretty Printing 2: Electric Boogaloo #407
Merged
pythongirl325
merged 6 commits into
jyn514:master
from
pythongirl325:pretty-printing-2-electric-boogaloo
May 6, 2020
Merged
Pretty Printing 2: Electric Boogaloo #407
pythongirl325
merged 6 commits into
jyn514:master
from
pythongirl325:pretty-printing-2-electric-boogaloo
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a better approach than before :) Lots of nits but the basic algorithm looks great.
jyn514
reviewed
May 6, 2020
jyn514
reviewed
May 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed pretty printing so that it actually works. Also added anonymous struct & union printing, although with bad wight-space (it needs another PR to fix). I haven't added this yet, but I want to implement some round trip testing for the system.