Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Space between function macro name and args #457

Closed
hdamron17 opened this issue May 26, 2020 · 2 comments · Fixed by #462
Closed

Space between function macro name and args #457

hdamron17 opened this issue May 26, 2020 · 2 comments · Fixed by #462
Labels
bug Something isn't working good first issue Good for newcomers preprocessor Issue in the preprocessor (probably cycle detection)

Comments

@hdamron17
Copy link
Collaborator

Using -E

Expected behavior

Function macro should be replaced when whitespace separates name and args. (this is true in clang at least)

<a>

Actual Behavior

Name is consumed but the macro is not replaced.

 (a)

Code

#define f(a) <a>
f (a)
@hdamron17 hdamron17 added the codegen Involves generating Cranelift IR label May 26, 2020
@hdamron17
Copy link
Collaborator Author

Didn't mean to add codegen label. Should be preprocessor, bug, and maybe good-first-issue.

@jyn514 jyn514 added bug Something isn't working good first issue Good for newcomers preprocessor Issue in the preprocessor (probably cycle detection) and removed codegen Involves generating Cranelift IR labels May 26, 2020
@jyn514
Copy link
Owner

jyn514 commented May 26, 2020

Looks like a regression from #437, this is working on 0.9.0.

@Stupremee Stupremee mentioned this issue Jun 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers preprocessor Issue in the preprocessor (probably cycle detection)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip whitespaces in preprocessor
2 participants
@hdamron17 @jyn514