Core: Fix support for multiple error classes

String#replace with a string argument replaces just once, not all matches. Closes gh-884
jquery-validation · Jan 14, 2014 · c1f0baf · c1f0baf
1 parent de830b3
commit c1f0baf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -511,7 +511,7 @@ $.extend($.validator, {
 		},
 
 		errors: function() {
-			var errorClass = this.settings.errorClass.replace(" ", ".");
+			var errorClass = this.settings.errorClass.split(" ").join('.');
 			return $(this.settings.errorElement + "." + errorClass, this.errorContext);
 		},
 

diff --git a/test/test.js b/test/test.js
@@ -479,14 +479,16 @@ test("option: errorClass with multiple classes", function() {
 	form.validate({
 		focusCleanup: true,
 		wrapper: "span",
-		errorClass: "error error1"
+		errorClass: "error error1 error2"
 	});
 	form.valid();
 	ok( form.is(":has(span:visible:has(label.error[for=username]))") );
 	ok( form.is(":has(span:visible:has(label.error1[for=username]))") );
+	ok( form.is(":has(span:visible:has(label.error2[for=username]))") );
 	$("#username").focus().trigger("focusin");
 	ok( !form.is(":has(span:visible:has(label.error[for=username]))") );
 	ok( !form.is(":has(span:visible:has(label.error1[for=username]))") );
+	ok( !form.is(":has(span:visible:has(label.error2[for=username]))") );
 });
 
 test("elements() order", function() {