Skip to content

Commit c1f0baf

Browse files
magicxiejzaefferer
authored andcommitted
Core: Fix support for multiple error classes
String#replace with a string argument replaces just once, not all matches. Closes gh-884
1 parent de830b3 commit c1f0baf

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/core.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ $.extend($.validator, {
511511
},
512512

513513
errors: function() {
514-
var errorClass = this.settings.errorClass.replace(" ", ".");
514+
var errorClass = this.settings.errorClass.split(" ").join('.');
515515
return $(this.settings.errorElement + "." + errorClass, this.errorContext);
516516
},
517517

test/test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,14 +479,16 @@ test("option: errorClass with multiple classes", function() {
479479
form.validate({
480480
focusCleanup: true,
481481
wrapper: "span",
482-
errorClass: "error error1"
482+
errorClass: "error error1 error2"
483483
});
484484
form.valid();
485485
ok( form.is(":has(span:visible:has(label.error[for=username]))") );
486486
ok( form.is(":has(span:visible:has(label.error1[for=username]))") );
487+
ok( form.is(":has(span:visible:has(label.error2[for=username]))") );
487488
$("#username").focus().trigger("focusin");
488489
ok( !form.is(":has(span:visible:has(label.error[for=username]))") );
489490
ok( !form.is(":has(span:visible:has(label.error1[for=username]))") );
491+
ok( !form.is(":has(span:visible:has(label.error2[for=username]))") );
490492
});
491493

492494
test("elements() order", function() {

0 commit comments

Comments
 (0)