Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin option "Expunge Deleted Records" points to nonexistent function #598

Open
hornmo opened this issue Feb 23, 2017 · 1 comment
Open

Comments

@hornmo
Copy link
Contributor

hornmo commented Feb 23, 2017

The admin sidebar has one item that links to a "cleanup" function of the AdminController. Although there is a function "expungeDeletedComponents" in the CleanupService, there is no calling function in the AdminController for this. The selection of this item results in a Tomcat 404 status page.

@hornmo
Copy link
Contributor Author

hornmo commented Apr 7, 2017

This is fixed in #601, but one problem that remains is the handling of HistoryEvents. When a title is deleted, the expunge function in KBComponent.groovy deletes only the participant:

ComponentHistoryEventParticipant.executeUpdate("delete from ComponentHistoryEventParticipant as c where c.participant = :component",[component:this]);

This leaves empty references in the remaining title, and if both are deleted, the historyEvent is orphaned. Therefore, the deletion of a title should probably delete the whole historyEvent. At least, historyEvents without participants should be catched by a cleanup run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant