Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix postgres environment variable #117

Merged
merged 1 commit into from
May 21, 2021
Merged

fix postgres environment variable #117

merged 1 commit into from
May 21, 2021

Conversation

tsuty
Copy link
Contributor

@tsuty tsuty commented May 20, 2021

I don't know if it's intentional implements that supporting PGPASS environment variable to set password on psqldef

The psql command used PGPASSWORD environment variable.

https://www.postgresql.org/docs/current/libpq-envars.html

PGPASSWORD behaves the same as the password connection parameter.

Should I support PGPASS for backward compatibility?

k0kubun
k0kubun approved these changes May 21, 2021
View reviewed changes
Copy link
Collaborator

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a coincidence, I tried to use $PGPASS today and yes, only $PGPASSWORD worked. I think we don't need to support $PGPASS.

@k0kubun k0kubun merged commit 364247a into sqldef:master May 21, 2021
@tsuty tsuty deleted the fix/postgres_password_env_name branch May 24, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsuty @k0kubun