Support SQL Server #120
Merged
Support SQL Server #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonots
reviewed
Jun 8, 2021
| @@ -220,6 +240,9 @@ Some of them can also be used for input schema file. | |||
| - SQLite3 | |||
| - Table: CREATE TABLE, DROP TABLE | |||
| - View: CREATE VIEW, DROP VIEW | |||
| - SQLServer | |||
There was a problem hiding this comment.
Suggested change
| - SQLServer | |
| - SQL Server |
is correct. ref. https://www.microsoft.com/ja-jp/sql-server/sql-server-downloads
sonots
reviewed
Jun 8, 2021
| @@ -438,13 +461,14 @@ To rename them, you would need to rename manually and use `--export` again. | |||
|
|
|||
| ## Development | |||
|
|
|||
| You can use the following command to prepare MySQL and PostgreSQL to be used for running tests. | |||
| You can use the following command to prepare MySQL, PostgreSQL and SQLServer to be used for running tests. | |||
There was a problem hiding this comment.
Suggested change
| You can use the following command to prepare MySQL, PostgreSQL and SQLServer to be used for running tests. | |
| You can use the following command to prepare MySQL, PostgreSQL and SQL Server to be used for running tests. |
ditto
k0kubun
approved these changes
Jun 8, 2021
|
Thanks for reviewing! |
|
👍 Published as v0.10.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use sqldef in SQL Server (MSSQL).
So I added support of MSSQL.
Add the syntax for mssql.
IDENTITY(N, M)CLUSTEREDNONCLUSTEREDSupport for the foloowing DDLs.
CREATE TABLE,DROP TABLECREATE VIEW,DROP VIEWIt does not yet support adding or altering columns or mssql specific data types like nvarchar.