Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psqldef: Escape DSN parts & Add PGSSLROOTCERT support #130

Merged
merged 2 commits into from
Jul 2, 2021
Merged

psqldef: Escape DSN parts & Add PGSSLROOTCERT support #130

merged 2 commits into from
Jul 2, 2021

Conversation

ackintosh
Copy link
Contributor

Escape DSN parts

Fixed the error on the DSN contains symbols.

$ export PGPASSWORD=".:?-&/%="
$ psqldef -U "user_.:?-&/%=" sandbox_db --skip-drop --file=test.sql
2021/07/02 16:26:34 Error on DumpDDLs: dial tcp: lookup user_.: no such host

Add PGSSLROOTCERT support

https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT

I believe both of them are useful in case of AWS IAM Database Authentication. 🚀

k0kubun
k0kubun approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun k0kubun merged commit a6d2a87 into sqldef:master Jul 2, 2021
@ackintosh ackintosh deleted the feature/uri-escape-and-sslrootcert branch July 2, 2021 12:27
@mi-wada mi-wada mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ackintosh @k0kubun