[sqlite3def] Add blob type support #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Nov 16, 2022
cmd/sqlite3def/sqlite3def_test.go
Outdated
| @@ -143,6 +143,20 @@ func TestSQLite3defConfigIncludesSkipTables(t *testing.T) { | |||
| assertEquals(t, apply, nothingModified) | |||
| } | |||
|
|
|||
| func TestSQLite3defBlobType(t *testing.T) { | |||
There was a problem hiding this comment.
Can you test this in TestApply? All the tests other than TestApply should only test CLI features, and SQL manipulation should be tested in cmd/sqlite3def/tests.yml because it's faster and less redundant.
There was a problem hiding this comment.
I was not aware of the YAML file. This project is very informative in the way of Golang testing...
I have fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added blob type support // Datatypes In SQLite
Some virtual table features (such as FTS) create blob columns internally. In that case users cannot avoid using blob types.