-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deferrable unique constraint for PostgreSQL #186
Conversation
@k0kubun In 52f4809 I tried to fix the sqlparser to accept the expected DDL, but when I run the tests I added, I get syntax errors. I spent several hours trying to debug it, but I still haven't been able to, partly because I'm new to goyacc. Can you see what I'm missing? By the way, if you think it is much easier for you to write another patch by yourself from scratch rather than reviewing my code, please feel free to close this PR 🙏
|
You declared new tokens on the parser side, but you didn't let the lexer generate the tokens. So those keywords were recognized as if they were normal identifiers instead of keywords. Fixing it is as simple as 16aa629. You also need to touch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Released as v0.11.24. |
This PR will make psqldef handle DDL like:
PostgreSQL: Documentation: 14: ALTER TABLE