Remove pg_dump dependency #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that looks great. I think it's okay to go with this once the existing integration tests pass. I appreciate your effort working on this. |
yudppp
force-pushed
the
feature/remove_pg_dump_dependency
branch
4 times, most recently
from
b53f211 to
0b8b365
Compare
yudppp
force-pushed
the
feature/remove_pg_dump_dependency
branch
from
385554b to
ab0b2fb
Compare
yudppp
force-pushed
the
feature/remove_pg_dump_dependency
branch
from
ab0b2fb to
ee15b0f
Compare
|
@k0kubun |
|
Sounds good. Thanks a lot! |
k0kubun
reviewed
Feb 8, 2021
Comment on lines
+168
to
+174
| if colDefault != nil || isPK { | ||
| if isPK { | ||
| col.IsPrimaryKey = true | ||
| } else { | ||
| col.Default = *colDefault | ||
| } | ||
| } |
There was a problem hiding this comment.
Just curious, did you have any reason why this wasn't:
if isPK {
col.IsPrimaryKey = true
}
if colDefault != nil {
col.Default = *colDefault
}More specifically, did you intend to skip setting col.Default when colDefault != nil and isPk are true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked
Drop pg_dump dependencyissue. #10.Easy to implement
Drop pg_dump dependencyandSupport SERIALtogether.@k0kubun
Please check my plan is correct.
TODO
Drop pg_dump dependenconly)