Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control plane contoller doesn't react on machineTemplate ref changes #808

Closed
makhov opened this issue Nov 12, 2024 · 1 comment · Fixed by #813
Closed

Control plane contoller doesn't react on machineTemplate ref changes #808

makhov opened this issue Nov 12, 2024 · 1 comment · Fixed by #813
Labels
bug Something isn't working
Milestone

Comments

@makhov
Copy link
Contributor

makhov commented Nov 12, 2024

What happened?

If the machineTemplate reference changes, k0smotron doesn't do anything.

Involved Areas

No response

What did you expect to happen?

k0smotron should create new machines and remove old ones

Steps to reproduce

  • Deploy a K0sControlPlane cluster
  • Change the machineTemplate reference

k0smotron version

v1.2.0 and below

k0s version

any

Anything else we need to know?

No response

@makhov makhov added the bug Something isn't working label Nov 12, 2024
@camusdv
Copy link

camusdv commented Nov 14, 2024

Changing VSphereMachineTemplate object reference in MachineDeployment object is applied. Thus worker nodes are able to be recreated with the updated flavor.

Changing VSphereMachineTemplate object reference in K0sControlPlane object is ignored. This control plane nodes are not recreated with the updated flavor.

There is a work-around by applying a K0s version upgrade with K0sControlPlane created with spec.updateStrategy=Recreate - https://docs.k0smotron.io/stable/update/update-capi-cluster/#updating-the-control-plane-using-the-cluster-api-workflow.

@makhov makhov added this to the 1.3 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants