Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipformer-adapter streaming_forward without adapters. #1553

Closed
kobenaxie opened this issue Mar 16, 2024 · 4 comments
Closed

zipformer-adapter streaming_forward without adapters. #1553

kobenaxie opened this issue Mar 16, 2024 · 4 comments

Comments

@kobenaxie
Copy link
Contributor

All adapters are only used in forward(), but not in streaming_forward, please fix it.

@marcoyang1998
Copy link
Collaborator

Thanks for pointing it out. I will try to add the support for streaming_forward this week.

@kobenaxie
Copy link
Contributor Author

Hi @marcoyang1998 , another question, when finetuning adapter or lora, is there any difference between optimizer with whole model parameters and optimizer with only adapter/lora module paramters ?

@marcoyang1998
Copy link
Collaborator

They should be equivalent as only the parameters in lora or adapter will have gradients, but the latter could be more efficient (not tested though) as it won't traverse all model parameters.

@marcoyang1998
Copy link
Collaborator

Fixed in #1560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants