Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add ARCHITECTURE.md to ease contributions #483

Closed
iwilltry42 opened this issue Feb 7, 2021 · 5 comments · Fixed by #680
Closed

[FEATURE] Add ARCHITECTURE.md to ease contributions #483

iwilltry42 opened this issue Feb 7, 2021 · 5 comments · Fixed by #680
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@iwilltry42
Copy link
Member

Alternatively folder level README.md files to describe project structure and ease contributions by showing people where code should be added.
Inspired by https://news.ycombinator.com/item?id=26048784

@iwilltry42 iwilltry42 added the enhancement New feature or request label Feb 7, 2021
@iwilltry42 iwilltry42 added this to the Backlog milestone Feb 7, 2021
@leelavg
Copy link
Contributor

leelavg commented Jun 29, 2021

Hi,

Any due date for this? I looked at CI yaml upto now but only PR logs (seems other events aren't publicly available)

About to look into code and having a reference would be helpful 🙂

@iwilltry42 iwilltry42 modified the milestones: Backlog, v5.0.0 Jun 29, 2021
@iwilltry42 iwilltry42 self-assigned this Jun 29, 2021
@iwilltry42
Copy link
Member Author

Hi @leelavg , good that you ask.
I added it to the v5.0.0 milestone now, as I think it's a nice to have asset to ease contributions 👍

I looked at CI yaml upto now but only PR logs (seems other events aren't publicly available)

Can you elaborate? I didn't get that 🤔

@leelavg
Copy link
Contributor

leelavg commented Jun 29, 2021

Can you elaborate?

I was able to see the logs for pr workflow but not for any merge/release workflows

@iwilltry42
Copy link
Member Author

(seems other events aren't publicly available)

There's absolutely nothing hidden in this project/repository (except for maybe the DockerHub secrets in DroneCI, as that is hosted by Rancher Labs) 🤔

I was able to see the logs for pr workflow but not for any merge/release workflows

Ah you mean the output of the DroneCI and GitHub Actions pipelines for releasing?

@leelavg
Copy link
Contributor

leelavg commented Jun 29, 2021

push events end up here (also does the releases, when a tag is pushed): https://drone-publish.rancher.io/rancher/k3d

Thanks a lot for the info, gone through everything else in the list except above. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants