-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k3s etcd-snapshot
commands run against server specified in config file, instead of local server
#10513
Comments
Some other testing considerations additional to what has already been listed
|
I am fixing this by changing the flags for server/token to etcd-server/etcd-token. The use case for this was primarily for folks that for some reason changed the bind address or supervisor port and needed to override the server address to match. We weren't REALLY expecting folks to run the command against other nodes. |
Validated on Version:-$ k3s version v1.30.2+k3s-37830fe1 (37830fe1)
Environment DetailsInfrastructure Node(s) CPU architecture, OS, and Version: Cluster Configuration: Steps to validate the fix
Reproduction Issue:
Validation Results:
|
Environmental Info:
K3s Version: v1.30.2+k3s2
Node(s) CPU architecture, OS, and Version:
n/a
Cluster Configuration:
Any cluster using embedded etcd with more than one server
Describe the bug:
This is a regression introduced by
When running
k3s etcd-snapshot
commands, theserver
flag defaults to the local server address, so etcd snaphots are created/listed/deleted on the local node. However, if the local server was joined to a cluster by specifying aserver
in the config file, theetcd-snapshot
commands are executed against THAT server, instead of the local server.This was reported in rancher/rke2#6284 but it took me a moment to realize what the user meant - I thought they were expecting the snapshot commands to be able to delete snapshots taken by other nodes (which is kind of what this is actually doing)
This is also likely the root cause of the multiple concurrent snapshot requests from #10371 - rancher's snapshot save commands were all being sent to the init node, instead of running locally on the individual servers.
Steps To Reproduce:
server:
address of the first node specified in the config file.Expected behavior:
etcd-snapshot
commands work against the local server by default, even when a server address is present in the config fileActual behavior:
As described above
Additional context / logs:
The text was updated successfully, but these errors were encountered: