-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k3s etcd-snapshot save fails on host with IPv6 only #9214
Comments
We've made some changes to the snapshot functionality in recent releases, can you try with the latest v1.26 patch release? |
Thanks for the hint, will give it a try... |
Hi @brandond Checked with
Any ideas? thnx |
Can you show how your node is configured for ipv6-only? What is the output of Generally speaking, k3s should detect ipv4 or ipv6 and set the loopback address appropriately, but for some reason that's not happening for you. |
Here it is:
|
Did you redact that, or are you really setting the node IP to that address? It is somewhat unusual to use a |
No, it is not redacted. t's the way how we configure hosts. |
Hmm. That is a little odd. Can you show the output of |
Hi @brandond to be on safe side, I spin new AWS EC2 instance with IPv6 only, (also the format of address is like you wish), but the symptoms are the same... See here: Server info:
K3s cluster info: (latest k3s version used)
On-demand Snapshot triggered, however the same error:
Automated snapshots created properly:
So it seems that this issue is not related to our environment only, but affects nodes with IPv6 in general. |
@brandond i checked the code and main problem is function getEndpoints Problem in setup of @PeterBarczi is empty endpoints runtime.EtcdConfig.Endpoints and control.ServiceIPRange isn't set too. So he will always get ipv4 for etcd db as default value from control.Loopback method Of course root cause will be something else. |
Hmm, that is interesting. If you don't set --service-cidr and --cluster-cidr to ipv6, wouldn't this leave you with an IPv4 cluster running on IPv6-only nodes? Does this work properly? We can take a look at putting both the ipv4 and ipv6 loopback addresses in the endpoint list; I think grpc should do the right thing and connect to whichever works. |
@brandond
with the same behavior:
|
What do you get for |
Here is the output:
|
Ah right, I forgot that we made improvements to ipv6-only; it is only dual-stack that requires manual configuration. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@lukas016 It looks like you have something else going on there... the data dir extraction suggests that you hadn't actually run this release of k3s before? You should upgrade the running k3s server instance to this release, before trying to use the CLI to take a snapshot. The Please open a new issue if you can reproduce problems when actually running a release of k3s that includes this change. |
Validated on Version:-$ k3s version v1.29.2+k3s-085ccbb0 (085ccbb0)
Environment DetailsInfrastructure Node(s) CPU architecture, OS, and Version: Cluster Configuration: Steps to validate the fix
Reproduction Issue:
Validation Results:
|
Working as expected using config but not with args on CLI, talking with @brandond we are letting this behind now to release the whole fix |
confirming, moving out to next release to extend fix to CLI args, not just config. |
Moving this out to next release; I am going to do some fairly invasive refactoring to move on-demand snapshots into a request/response model where the running server process actually does the snapshot, instead of trying to set up the complete server context within the on-demand snapshot CLI. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
ipv6 only validation |
Environmental Info:
K3s Version:
v1.26.9+k3s1
Node(s) CPU architecture, OS, and Version:
Linux test-n1 6.1.13-gardenlinux-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.13-0gardenlinux~0 (2023-03-17) x86_64 GNU/Linux
Cluster Configuration:
Describe the bug:
k3s etcd-snapshot save
fails on host with IPv6(automated snapshots are present)
Steps To Reproduce:
run
k3s etcd-snapshot save
on host with IPv6 networking onlyExpected behavior:
on-demand snapshot successfully created
Actual behavior:
unable to create on-demand snapshot via
etcd-snapshot save
Additional context / logs:
The text was updated successfully, but these errors were encountered: