Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid DeleteRange response: "..." with 1.26.0-rc.0 #145

Closed
neoaggelos opened this issue Nov 18, 2022 · 0 comments · Fixed by #146
Closed

invalid DeleteRange response: "..." with 1.26.0-rc.0 #145

neoaggelos opened this issue Nov 18, 2022 · 0 comments · Fixed by #146

Comments

@neoaggelos
Copy link
Contributor

Summary

kubernetes/kubernetes@421213b is now checking that the delete response range is valid. Kine seems to be returning an invalid response, which contains a ResponseRange instead of a ResponseDeleteRange, looking at https://github.com/k3s-io/kine/blob/master/pkg/server/delete.go#L30-L50

I've done some early testing with fixing the response format, but not sure if there is a blast radius that I am missing. Hoping to get some feedback from kine maintainers.

I'm creating a PR with my work, let's see where the discussion takes us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant