Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically setting image codec #1204

Closed
Migushthe2nd opened this issue Oct 31, 2024 · 2 comments
Closed

Automatically setting image codec #1204

Migushthe2nd opened this issue Oct 31, 2024 · 2 comments
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request

Comments

@Migushthe2nd
Copy link

I quite often used video2x to upscale images. v6.0.0 currently does not save png images as png format by default as the libx264 vcodec is used. It would be nice if it was automatically set to the png codec (similarly e.g. jpeg2000 for jpegs)
@k4yt3x
Copy link
Owner

k4yt3x commented Oct 31, 2024

I didn't design this version to work with images at all actually... It's something we could optimize for in the future.

@k4yt3x k4yt3x added type:Enhancement New feature or request state:Planned This issue is already scheduled to be worked on labels Oct 31, 2024
@k4yt3x k4yt3x mentioned this issue Dec 19, 2024
Closed
@k4yt3x k4yt3x added state:InProgress This issue is being worked on and removed state:Planned This issue is already scheduled to be worked on labels Jan 24, 2025
@k4yt3x
Copy link
Owner

k4yt3x commented Jan 24, 2025 •
edited
Loading

Added in: k4yt3x/video2x-qt6@8a1b5b3. Will be in the next release.

Now it automatically sets image output codec to PNG, which is probably a good default for decent quality output and compatibility.

Image

@k4yt3x k4yt3x closed this as completed Jan 24, 2025
@github-actions github-actions bot added state:Done This issue has been resolved/dismissed and removed state:InProgress This issue is being worked on labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:Done This issue has been resolved/dismissed type:Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k4yt3x @Migushthe2nd