Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason not to use ffmpeg's -vf scale=wxh:flags=lanczos ? #610

Closed
Boteium opened this issue Mar 8, 2022 · 3 comments
Closed
Labels
state:InProgress This issue is being worked on

Comments

@Boteium
Copy link

Boteium commented Mar 8, 2022

I think the downscale part can be done by ffmpeg's lancoz downscale filter and remove the need to re-scale it by python.
It's much faster and efficient. The downscale and encoding process can be done together in only one step.
There is really no need to add parallelism in python in the next version when ffmpeg can already do that.

@k4yt3x
Copy link
Owner

k4yt3x commented Mar 8, 2022

Sounds like a nice idea, I'll try implementing that.

@k4yt3x k4yt3x added component:FFmpeg state:InProgress This issue is being worked on labels Mar 8, 2022
@k4yt3x k4yt3x closed this as completed Oct 8, 2024
@thekryz
Copy link

thekryz commented Feb 7, 2025

does this work now? What does the flag have to look like for video2x command line version?
Would love to use this with real-esrgan to downscale after upscaling by a fixed factor.

@k4yt3x
Copy link
Owner

k4yt3x commented Feb 7, 2025

@thekryz No it wasn't implemented in the new version yet. Implementing this is more complex with the C++ version since we aren't calling FFmpeg commands anymore and it's no longer a simple string. We'll need to create buffer sinks and filtergraphs. It's most likely going to be added in #1196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:InProgress This issue is being worked on
Projects
None yet
Development

No branches or pull requests

3 participants