Are necessary any implicit changes made by GitLocalize?

[buslov]

GitLocalize adds some changes when making a pull-request:

• Replaces * by - in lists
  
• Extra empty lines
  
• Completely breakes TOC's links
  
• Deletes redundant backquotes
  
• Changes formatting characters:
  
• Decodes (some?) HTML entities:
  

[RichardLitt]

@sotayamashita these changes seem out of scope for a translation engine. Are they necessary?

[sotayamashita]

@RichardLitt GitLocalize changes some markdown following flow. In GitLocalize, we parse markdown and convert it into HTML to translate. After translating, we convert HTML to markdown based on commonmark spec. A series of the flow, we change some markdown.

We understand that issue but it will rendered same before. Is there a problem?

Thanks in advance. 🙇

[RichardLitt]

Good to know. You're right, most of these are superficial. However, the TOC changes aren't - as far as I know, they will break the links. @buslov can you confirm this?

[buslov]

@RichardLitt, you are right. I suppose that GitLocalize just copies links from English source. We could add some tests (#205) to Travis CI to prevent any merges with broken links.