Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorthand for the http flag in serve command #969

Merged

Conversation

VaibhavMalik4187
Copy link
Contributor

Closes #968

📑 Description

Removed the shorthand for the http flag in the serve command because it was contradicting with the shorthand of the help command which is automatically added on execution if the help flag is not already defined.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VaibhavMalik4187 VaibhavMalik4187 requested review from a team as code owners February 19, 2024 05:47
Removed the shorthand for the `http` flag in the serve command because
it was contradicting with the shorthand of the `help` command which is
automatically added on execution if the `help` flag is not already
defined.

Fixes: k8sgpt-ai#968

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@AlexsJones AlexsJones merged commit f55f837 into k8sgpt-ai:main Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Panic on running the serve command
2 participants