Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract task execution attributes into an inlined struct #457

Closed
olim7t opened this issue Nov 21, 2022 · 0 comments · Fixed by #458
Closed

Extract task execution attributes into an inlined struct #457

olim7t opened this issue Nov 21, 2022 · 0 comments · Fixed by #458
Labels
enhancement New feature or request

Comments

@olim7t
Copy link
Contributor

olim7t commented Nov 21, 2022

What is missing?

In k8ssandra/k8ssandra-operator#739 we will introduce a K8ssandraTask resource, that triggers a CassandraTask for each datacenter in the cluster:

apiVersion: control.k8ssandra.io/v1alpha1
kind: K8ssandraClusterTask
metadata:
  name: upgradesstables
spec:
  cluster:
    name: cluster1
  datacenters:
    - dc3
    - dc1
  spec:
    jobs:
      - name: upgradesstables-dc1
        command: upgradesstables

The spec part is almost identical to CassandraTask, except that it won't have a datacenter field. It would be nice to have a struct that we can reuse, instead of duplicating all the required fields.

Why do we need it?

Code reuse, maintainability.

Environment

Any.

  • Cass Operator version: > 1.13.1

Anything else we need to know?:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant