-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set verbosity level in logging statements #282
Comments
sync-by-unito
bot
changed the title
Set verbosity level in logging statements
K8SSAND-1152 ⁃ Set verbosity level in logging statements
Jan 10, 2022
Kubernetes recommends max V(1) for debugging, not deeper. |
Can you provide a reference? So nothing greater than V(1)? |
Here are logging guidelines for kubernetes dev docs https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md. It suggests V(4) for debug and a default level of V(2). |
5 tasks
sync-by-unito
bot
changed the title
K8SSAND-1152 ⁃ Set verbosity level in logging statements
Set verbosity level in logging statements
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is missing?
Most (maybe all) logging throughout the operator are done with
logger.Info()
andlogger.Error()
. A verbosity should be set for each statement, e.g.,logger.V(5).Info()
.Why do we need it?
As the code base has grown there is a lot more logging output from the operator. A lot of the log statements are really only needed during dev/testing or debugging. By setting verbosity levels we give the user the ability to configure and tune logging output.
This is critical from a usability standpoint IMO.
It probably makes sense to configure the logging level via the operator configuration which means we need to do #63.
Environment
┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: K8OP-120
The text was updated successfully, but these errors were encountered: