Replies: 1 comment
-
should be fixed with #889 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In values.yaml we have image.registry parameter where we can set custom registry to pull k8up image from.
Why dont make the same logic available on the cleanup hook deployment?
Then, instead of having the image hardcoded in the cleanup-hook template
image: "bitnami/kubectl:latest
(https://github.com/k8up-io/k8up/blob/master/charts/k8up/templates/cleanup-hook.yaml#L86)It could be improved to
image: "{{ .Values.image.registry }}/bitnami/kubectl:latest
similar to what we have in the deployment template. (https://github.com/k8up-io/k8up/blob/master/charts/k8up/templates/deployment.yaml#L29)Or add more fields to values.yaml that could allow this container to be fully customizable. Is this something doable or something that I can contribute on?
Beta Was this translation helpful? Give feedback.
All reactions