Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on 1.3.4.4 #176

Closed
dnish opened this issue Jul 14, 2016 · 18 comments
Closed

Not working on 1.3.4.4 #176

dnish opened this issue Jul 14, 2016 · 18 comments

Comments

@dnish
Copy link
Contributor

dnish commented Jul 14, 2016

Hey,
Fast Render seems to be broken on my 1.3.4.4 application with Iron Router. The Meteor.user() object isn't available on the initial page load, everything worked fine before upgrading from 1.2 to 1.3.

@jschlieber
Copy link

I'm also having issues with the latest fast-render and Meteor 1.3.4.4 (same with flow-router-ssr and react-router-ssr). Server side injected data isn't there at initial page load. Downgrading to fast-render@2.13.0 (kind of) solved those issues (as long as I don't make use of subs manager).

@VitalyChe
Copy link

VitalyChe commented Jul 15, 2016

It seems the FastRender injects the DDP messages correctly (when no connection yet) but the messages (came with html especially user data) never get processed and saved into collections due to Accounts _autoLoginEnabled=true. Enabled autoLogin is the first to send message (login) to the live data connection (token is taken from local storage)
After that every message is buffered (that the FastRender injects) but is not processed due to _waitingForQuiescence (the first login message is there) until the connection is established

It happens when there is some delay before connection is established

@SachaG
Copy link

SachaG commented Aug 6, 2016

Has anybody found a fix for this? I can confirm this started happening with 1.3.3 by the way.

@abernix I saw you've been contributing to FR, maybe you'd have some input on the issue?

@tmeasday
Copy link

tmeasday commented Aug 10, 2016

Looks like it already has been fixed: #167 ?

@tmeasday
Copy link

You can turn off buffered DDP with Meteor.connection.bufferedWritesMaxAge = 0 to work around this, I would guess.

@SachaG
Copy link

SachaG commented Aug 10, 2016

Note that it's actually Meteor.connection._bufferedWritesMaxAge = 0 (on the client). Still doesn't fix the problem sadly :(

@tmeasday
Copy link

It was an issue with the fix for #167 (https://github.com/kadirahq/fast-render/pull/167/files#r74189260)

I would suggest downgrading to 2.13.x and potentially using the bufferedWrites workaround (although your reproduction works for me without it).

@tmeasday
Copy link

tmeasday commented Aug 10, 2016

(and the fix for this package is to revert the linked commit). cc @arunoda

@arunoda
Copy link
Contributor

arunoda commented Aug 10, 2016

Thanks @tmeasday I'll experiment with this today and do a release.
@SachaG could you verify that downgrading this solves your issue?

@SachaG
Copy link

SachaG commented Aug 10, 2016

Yes, I can confirm 2.13.0 doesn't have this problem.

@SachaG
Copy link

SachaG commented Aug 10, 2016

Hmm, that being said with 2.13.0 I seem to have reloading problems for non-logged-in users in Telescope. I'm not sure if it's a Telescope-specific issue though.

@tmeasday
Copy link

There could definitely be problems with 2.13 and 1.3.3 if you don't turn off DDP batching, I expect.

@gbhrdt
Copy link

gbhrdt commented Aug 10, 2016

Did you already look into this @arunoda ? :) this has pretty high severity for us right now.

@queso
Copy link

queso commented Aug 17, 2016

@arunoda: Any update on this? Kind of a blocker to launching a newer/faster SSR crater site....

@dnish
Copy link
Contributor Author

dnish commented Aug 19, 2016

Downgrading to 2.13.0 doesn't work very well (on some reloads everything works fine, on others I get a "expected document to change" error without having the initial user data).

@dnish
Copy link
Contributor Author

dnish commented Aug 20, 2016

Maybe somone here can check the fix #184 on his local project? In my case, everything is working fine now without problems.

cd your-meteor-project/packages
git clone https://github.com/dnish/fast-render
cd .. && meteor add meteorhacks:fast-render

@gbhrdt
Copy link

gbhrdt commented Aug 20, 2016

@dnish I just tested your fix, seems to be working for me, thanks!

@arunoda
Copy link
Contributor

arunoda commented Aug 21, 2016

@dnish Hey thanks a lot for your fix. I just got it and did a release as v2.16.0.
Try that.

Thanks all for helping on this.

@dnish dnish closed this as completed Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants