Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deployment custom labels #18

Closed
4 tasks done
crimarz opened this issue Jun 20, 2024 · 1 comment · Fixed by #27
Closed
4 tasks done

add deployment custom labels #18

crimarz opened this issue Jun 20, 2024 · 1 comment · Fixed by #27
Labels
good first issue Up for grabs type/enhancement En enhancement/improvement to an already existing feature

Comments

@crimarz
Copy link

crimarz commented Jun 20, 2024

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here (legacy) and here
  • I've tried installing latest charts and the issue still persists there
  • I'm running a supported version of the application & chart which is listed here

Describe the bug (actual behavior)

I think it will be useful to permit custom labels for deployment as already in place for pods (.Values.podLabels)

Expected behavior

possibility to set a new value (.Values.deploymentLabels ? ) with a list of custom labels for deployment

Your installation details

Appversion:v1.0.0
Chartversion:kafka-ui-1.4.0

Steps to reproduce

n/a

Screenshots

No response

Logs

No response

Additional context

No response

@crimarz crimarz added the status/triage Issues pending maintainers triage label Jun 20, 2024
@Haarolean
Copy link
Member

Hi, feel free to raise a PR for this :)

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature and removed status/triage Issues pending maintainers triage labels Jul 2, 2024
@Haarolean Haarolean added the good first issue Up for grabs label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants