Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Upload images to a public AWS ECR #242

Closed
2 tasks done
Haarolean opened this issue Mar 22, 2024 · 9 comments · Fixed by #347
Closed
2 tasks done

Infra: Upload images to a public AWS ECR #242

Haarolean opened this issue Mar 22, 2024 · 9 comments · Fixed by #347
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Milestone

Comments

@Haarolean
Copy link
Member

Haarolean commented Mar 22, 2024

We currently publish to github (and mirror to DockerHub), but I'll raise an issue and discuss the possibility of uploading the images to a public ECR as well.

Originally posted by @Haarolean in #23 (reply in thread)

TODO:

@kapybro kapybro bot added status/triage Issues pending maintainers triage scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Mar 22, 2024
@Haarolean Haarolean changed the title Infra: Consider uploading images to a public AWS ECR Infra: Upload images to a public AWS ECR Apr 10, 2024
@Haarolean Haarolean added the status/needs-attention Collective discussion is required label Apr 10, 2024
@Haarolean Haarolean moved this to Backlog in Housekeeping Apr 27, 2024
@yermulnik
Copy link

@Haarolean Have there been any updates on this recently? Thanks.

@Haarolean Haarolean added this to the 1.1 milestone Oct 7, 2024
@Haarolean Haarolean removed the status/needs-attention Collective discussion is required label Oct 7, 2024
@Haarolean Haarolean removed this from Housekeeping Oct 7, 2024
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.1 Oct 7, 2024
@Haarolean Haarolean added the type/enhancement En enhancement/improvement to an already existing feature label Oct 7, 2024
@Haarolean Haarolean moved this to PR Approved in Up for grabs Oct 7, 2024
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Up for grabs Oct 7, 2024
@github-project-automation github-project-automation bot moved this from PR Approved to Done in Release 1.1 Oct 7, 2024
@yermulnik
Copy link

@Haarolean Just to reconfirm: this is the correct AWS Public ECR repo — https://gallery.ecr.aws/s0v8j8q9/kafbat/kafka-ui, right?
image

Can the s0v8j8q9 id be dropped from the path and the description added to the repo for visibility? Thank you.

@Haarolean
Copy link
Member Author

@yermulnik yeah it's the right one. The id can't be dropped (unless you know something we don't :) ), the first deploy should be performed once #586 is merged and we'll update the description soon

@yermulnik
Copy link

Thank you.
We can expect version and latest tags to be added as well, right? 😺

@yermulnik
Copy link

The id can't be dropped (unless you know something we don't :) )

FWIW: https://aws.amazon.com/blogs/aws/amazon-ecr-public-a-new-public-container-registry/
image

ps: hope this helps as I haven't done this myself before 🤷🏻

@Haarolean
Copy link
Member Author

Thank you. We can expect version and latest tags to be added as well, right? 😺

latest will be pushed there once 1.1 is released, will that work for you?

@yermulnik
Copy link

Thank you. We can expect version and latest tags to be added as well, right? 😺

latest will be pushed there once 1.1 is released, will that work for you?

Absolutely. Appreciate it 👍🏻

@yermulnik
Copy link

@Haarolean Given the number of tasks for 1.1 milestone, are there any approx timelines for that release? 🤔 Past due by 8 months 😢

FWIW: aws.amazon.com/blogs/aws/amazon-ecr-public-a-new-public-container-registry

Did I get it right, that you decided to not go with custom registry alias for a reason?

Also is the main tag re-added for every new commit'ish tag? (trying to figure out what we should rely upon unless releases are tagged correctly going forward).
Thanks.

@Haarolean
Copy link
Member Author

are there any approx timelines for that release

Yeah, once #72 is merged in.

Did I get it right, that you decided to not go with custom registry alias for a reason?

Nope. I believe we didn't get the alias approved or something. I'll take a look into that.

Also is the main tag re-added for every new commit'ish tag

Yeah, that's right. It always points to the latest commit in main.
Besides the main and release tags, every other commit in main has its own tag. You can use one of these.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants