Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group instance ID support (group.instance.id) (static membership) #526

Open
anoskov opened this issue Aug 18, 2022 · 3 comments
Open

Group instance ID support (group.instance.id) (static membership) #526

anoskov opened this issue Aug 18, 2022 · 3 comments

Comments

@anoskov
Copy link

anoskov commented Aug 18, 2022

Hello!
It is possible to add group instance ID support for static membership. This allows in some cases reduce consumer rebalances.

Details: KIP-345

@zmstone
Copy link
Contributor

zmstone commented Aug 20, 2022

The underlying protocol library already supports it,
however we do not have the plan to support it in brod yet, not at the moment.

ref: https://github.com/kafka4beam/kafka_protocol/blob/7147d6e16652b9b1c39758250bdf93ee934ec706/src/kpro_schema.erl#L499-L517

@anoskov
Copy link
Author

anoskov commented Aug 20, 2022

@zmstone thanks for reply!
Correctly I understand that we should pass this to coordinators state and after to join_group and sync_group requests body?

https://github.com/kafka4beam/brod/blob/master/src/brod_group_coordinator.erl#L616
https://github.com/kafka4beam/brod/blob/master/src/brod_group_coordinator.erl#L652

@zmstone
Copy link
Contributor

zmstone commented Aug 26, 2022

Hi @anoskov
I'm afraid it's more than just adding the fields.

I had a quick look at KIP before, and just quickly revisited it,
It seems that "Client Behavior Changes" implies brod_group_coordinator should change in its rebalance behaviours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants