You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello brod maintainers! I noticed a slight inconsistency/oversight in how the begin offset is resolved for consumer groups.
The docs and type spec would lead me to believe that the begin_offset in the consumer config should be treated as a :brod.offset_time(). The atom values (:earliest and :latest) seem to be handled correctly. However, if you try to use a :brod.msg_ts() type value, it is handled as a resolved offset, not a timestamp.
Obviously, not using :earliest or :latest is a niche use case but, in that case, handling it as a timestamp seems to be the desired behavior.
This is fairly easy to recreate, using the following child_spec. Everything behaves as expected in this case but, if you attempt to use a timestamp for the begin_offset field of the consumer config, you'll notice it's treated as an offset and NOT a timestamp:
Hello brod maintainers! I noticed a slight inconsistency/oversight in how the begin offset is resolved for consumer groups.
The docs and type spec would lead me to believe that the
begin_offset
in the consumer config should be treated as a:brod.offset_time()
. The atom values (:earliest
and:latest
) seem to be handled correctly. However, if you try to use a:brod.msg_ts()
type value, it is handled as a resolved offset, not a timestamp.Obviously, not using
:earliest
or:latest
is a niche use case but, in that case, handling it as a timestamp seems to be the desired behavior.This is fairly easy to recreate, using the following child_spec. Everything behaves as expected in this case but, if you attempt to use a timestamp for the
begin_offset
field of the consumer config, you'll notice it's treated as an offset and NOT a timestamp:Not a super big deal but it would be nice to have this functionality (or at least update the spec to reduce future confusion)
The text was updated successfully, but these errors were encountered: