Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka network throttling-related issues are hard to detect #63

Open
k32 opened this issue Nov 1, 2019 · 1 comment
Open

Kafka network throttling-related issues are hard to detect #63

k32 opened this issue Nov 1, 2019 · 1 comment

Comments

@k32
Copy link

k32 commented Nov 1, 2019

Kafka has a setting that introduces rate limiting for clients. kafka_protocol could be more informative in the situations when this happens

@zmstone
Copy link
Contributor

zmstone commented Nov 1, 2019

Which version?
As far as I know, kafka dose this by sending back a non zero in throttle_time_ms field.
If we are to throttle connection process, it’s going to be unfair because

  1. brod sends per partition produce requests, the protocol allows collective message sets for different topic-partitions. presumably it is unfair for brod if throttling is rate based.
  2. Connection is shared between different topic-partitions in brod.

Maybe this is something for brod to fix, but not here in kafka_protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants