-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I/O error with third party application #522
Comments
I am seeing this with Peertube also. |
I think this is a goofys bug. After a quick scan, I think the bug is this goofys sends HeadBlob("") to s3 when xattrs are being fetched on the root inode. s3 client is rejecting the api because it expects a non empty path for the head request. Goofys should return empty list when it gets xattr request results in HeadBlob("") |
@dotslash Thanks for the hint. I had the same problem and made the following change (1 is the root inode): diff --git a/internal/goofys.go b/internal/goofys.go
index b78d215..bc90187 100644
--- a/internal/goofys.go
+++ b/internal/goofys.go
@@ -462,11 +462,15 @@ func (fs *Goofys) GetXattr(ctx context.Context,
func (fs *Goofys) ListXattr(ctx context.Context,
op *fuseops.ListXattrOp) (err error) {
+ var xattrs []string
+
fs.mu.RLock()
inode := fs.getInodeOrDie(op.Inode)
fs.mu.RUnlock()
- xattrs, err := inode.ListXattr()
+ if inode.Id != 1 {
+ xattrs, err = inode.ListXattr()
+ }
ncopied := 0 Not sure if it is the 100% correct way of doing this. But with this change, I am finally able to take backups with restic from a goofys mount. |
I'm getting the same issue using borg backup. Most notably getting an Errno 5. Full error coming from borg backup is:
Debugging the mount, I got the following error:
|
So I'm trying to have a third pary tool (Acronis Backup) to include a Goofy mounted S3 bucket in the backup, but it seems to fail. Of course I'm not gonna blame Goofy, but was hoping that maybe I could do something to fix it.
When the backup tool tries to get a hold of the files, I see this error:
So something is pointed at xattr. In old issues I see that it's not supported but in the latest version (v0.24.0 - which I use) I see something about xattr, which makes me unsure.
Is there anything I can do.
The text was updated successfully, but these errors were encountered: