Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate inode created on MkDir when executed simultaneously with same name #571

Open
skuppa opened this issue Oct 26, 2020 · 2 comments
Open

Comments

@skuppa
Copy link
Contributor

skuppa commented Oct 26, 2020

The goofy restarts on when same directory created simultaneously. The stack trace from goofy is

panic: double insert of some_name/folders/37079

goroutine 11332 [running]: github.com/kahing/goofys/internal.(*Inode).insertChildUnlocked(0xc00026e900, 0xc000685710) /root/go/src/github.com/kahing/goofys/internal/handles.go:246 +0x4bd
github.com/kahing/goofys/internal.(*Goofys).insertInode(0xc000290c30, 0xc00026e900, 0xc000685710) /root/go/src/github.com/kahing/goofys/internal/goofys.go:687 +0x54
github.com/kahing/goofys/internal.(*Goofys).MkDir(0xc000290c30, 0xd3a200, 0xc000dbf050, 0xc000d422a0, 0x0, 0x0) /root/go/src/github.com/kahing/goofys/internal/goofys.go:1029 +0x1a7
github.com/jacobsa/fuse/fuseutil.(*fileSystemServer).handleOp(0xc000398ba0, 0xc0002905b0, 0xd3a200, 0xc000dbf050, 0xa2e7c0, 0xc000d422a0) /root/go/pkg/mod/github.com/jacobsa/fuse@v0.0.0-20180417054321-cd3959611bcb/fuseutil/file_system.go:154 +0xb0b
created by github.com/jacobsa/fuse/fuseutil.(*fileSystemServer).ServeOps /root/go/pkg/mod/github.com/jacobsa/fuse@v0.0.0-20180417054321-cd3959611bcb/fuseutil/file_system.go:121 +0x173
@skuppa-veeva
Copy link

Here is PR to fix this issue:

#572

@skuppa-veeva
Copy link

@kahing I created a PR to fix this issue, could you review and let me know your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants